Open
Conversation
|
Build for commit 1409926 deployed to: https://scratchpad-pr-26.ci.next.deskprodemo.com URLs: |
zpawn
reviewed
Nov 12, 2024
| )} | ||
| text={<FormattedMessage id="button.clear" />} | ||
| /> | ||
| <H1 style={{ color: "#8B9293" }}> |
Contributor
There was a problem hiding this comment.
Please use colors from the theme context instead of hardcoding them.
|
|
||
| export default function TranslatedApp(props: { children: ReactNode }) { | ||
| const { context } = useDeskproLatestAppContext(); | ||
| const locale = context?.data?.app?.locale ?? 'en-GB'; |
Contributor
There was a problem hiding this comment.
What if the context contains a locale that isn't listed in the locales array in manifest.json?
Contributor
There was a problem hiding this comment.
…and we don’t have any translation files for it?
zpawn
reviewed
Nov 13, 2024
Contributor
There was a problem hiding this comment.
Description is usually showed as an iframe specified by the appStoreUrl in manifest.json. How should translation work in this case?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Evidence
This change uses the new manifest updates to allow the app to support multiple languages. For now, I've added Spanish just to show that the language to does change.